Skip to content

KAFKA-19535: add integration tests for DescribeProducersOptions#brokerId#20420

Merged
chia7712 merged 6 commits into
apache:trunkfrom
apalan60:KAFKA-19535
Sep 3, 2025
Merged

KAFKA-19535: add integration tests for DescribeProducersOptions#brokerId#20420
chia7712 merged 6 commits into
apache:trunkfrom
apalan60:KAFKA-19535

Conversation

@apalan60

@apalan60 apalan60 commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

Add tests for producer state listing with, without, and invalid
brokerId.

Reviewers: TengYao Chi kitingiao@gmail.com, Chia-Ping Tsai
chia7712@gmail.com

@github-actions github-actions Bot added triage PRs from the community tests Test fixes (including flaky tests) clients labels Aug 27, 2025
@apalan60

Copy link
Copy Markdown
Contributor Author

I looped this test 100 times, and it passed consistently, reducing the risk of flakiness.

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apalan60 thanks for this patch.

@github-actions github-actions Bot removed the triage PRs from the community label Aug 30, 2025
@apalan60

Copy link
Copy Markdown
Contributor Author

@chia7712
Thanks for your review. All comments are addressed.

@frankvicky frankvicky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apalan60: LGTM

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apalan60 thanks for this patch. two small comments are left. PTAL

@apalan60

Copy link
Copy Markdown
Contributor Author

@chia7712
Thanks for taking another look. I’ve updated it!

@chia7712 chia7712 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712
chia7712 merged commit a9bce06 into apache:trunk Sep 3, 2025
23 checks passed
eduwercamacaro pushed a commit to littlehorse-enterprises/kafka that referenced this pull request Nov 12, 2025
…Id (apache#20420)

Add tests for producer state listing with, without, and invalid
brokerId.

Reviewers: TengYao Chi <kitingiao@gmail.com>, Chia-Ping Tsai
 <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-approved clients tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants